Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix slot data for cancelled transition #6314

Merged
merged 2 commits into from
Jul 26, 2021
Merged

fix slot data for cancelled transition #6314

merged 2 commits into from
Jul 26, 2021

Conversation

tanhauhau
Copy link
Member

Fixes #5394

Before submitting the PR, please make sure you do the following

  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with npm test and lint the project with npm run lint

@Conduitry

This comment has been minimized.

Sign in to view
@tanhauhau tanhauhau force-pushed the tanhauhau/gh-5394 branch 2 times, most recently from 81448df to ba67654 Compare June 22, 2021 15:47
@tanhauhau tanhauhau force-pushed the tanhauhau/gh-5394 branch from ba67654 to 1b70fc7 Compare June 22, 2021 16:12
@tanhauhau tanhauhau force-pushed the tanhauhau/gh-5394 branch from 8ffd81b to e46cb7a Compare June 23, 2021 07:12
@tanhauhau

This comment has been minimized.

Sign in to view
@benmccann benmccann mentioned this pull request Jul 23, 2021
Closed
@Conduitry Conduitry merged commit d75ed6a into sveltejs:master Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Slot having stale state if transition is reversed midway
2 participants
@tanhauhau @Conduitry